Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax error in configuration #153

Closed
bilo-io opened this issue May 16, 2021 · 2 comments · Fixed by #164
Closed

Syntax error in configuration #153

bilo-io opened this issue May 16, 2021 · 2 comments · Fixed by #164
Labels

Comments

@bilo-io
Copy link

bilo-io commented May 16, 2021

Hey so, I think there is a syntax error in the README.md to set up this addon which would be corrected with the following:

- export parameters = {
+ export const parameters = {
    // Override the default dark theme
    darkMode: {

image

  • I may be wrong in that this is now possible with a later version of ECMAscript, or perhaps something specific to Storybook?
  • However, when I used the code suggestion in the README.md the code would not compile!
  • This might be an oversight, but let me know in case there's something I'm not aware of ...
  • Otherwise please update ... for the community
  • I can also create a PR 🤷
@hipstersmoothie
Copy link
Owner

Looks to be! make a pr and I'll merge

@hipstersmoothie
Copy link
Owner

🚀 Issue was released in v1.0.9 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants