Support workspaces #1500
Support workspaces #1500
Conversation
The location of `node_modules` is not guaranteed to be relative to the current directory (e.g. in yarn workspaces). A better solution here is to update package.json `exports` to include the file.
|
|
| @@ -1,5 +1,6 @@ | |||
| import yargs from "yargs"; | |||
| import { hideBin } from "yargs/helpers"; | |||
| import { join } from "node:path"; | |||
There was a problem hiding this comment.
Looks like it's not being used
|
Good catch, thank you for opening this PR @bradleyayers |
|
One thing to check is whether require.resolve is the correct API to use for ESM output, i'm not sure. And also the point about instead of doing a manual path concat i think it's better if the target file is made one of the exports in package.json. |
|
Hey @bradleyayers Do you think you'll have time to do it or should I take over the task (and credit you in my commit)? |
|
Please take this over that would be amazing, thank you. |
|
Superseded by #1514 |
The location of
node_modulesis not guaranteed to be relative to the current directory (e.g. in yarn workspaces).A better solution here is to update package.json
exportsto include the file.Description
Breaking change?
Example
Checklist