Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display dropped label for all dropped tx statuses #1919

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

He1DAr
Copy link
Collaborator

@He1DAr He1DAr commented Nov 20, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Display dropped label for all dropped tx statuses.

Issue ticket number and link

closes #1907

Checklist:

  • I have performed a self-review of my code.
  • I have tested the change on desktop and mobile.
  • I have added thorough tests where applicable.
  • I've added analytics and error logging where applicable.

Screenshots (if appropriate):

Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 8:04pm
hiro-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 20, 2024 8:04pm

@He1DAr He1DAr force-pushed the feat/display-dropped-label-for-all-dropped-tx-statuses branch from 9d7712c to 1440749 Compare November 20, 2024 19:58
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/common/utils/transactions.ts 0.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

TX page has non-exhaustive handling of TX statuses
2 participants