Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bigint arguments #1678

Closed
obycode opened this issue Apr 19, 2024 · 4 comments
Closed

bigint arguments #1678

obycode opened this issue Apr 19, 2024 · 4 comments
Assignees
Labels
feature Brand new functionality. New pages, workflows, endpoints, etc.

Comments

@obycode
Copy link
Member

obycode commented Apr 19, 2024

Problem

For all of the functions that take in values that represent Clarity ints and uints, they should probably accept bigint | number, since these types can be larger than a number (128-bit vs 64-bit).

Solution

Update the parameter types to be bigint | number.

Additional context

@obycode obycode added the feature Brand new functionality. New pages, workflows, endpoints, etc. label Apr 19, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in DevTools Apr 19, 2024
@janniks
Copy link
Collaborator

janniks commented Apr 19, 2024

🙏🏻 We typically have an IntegerType for this where was it missing?

@obycode
Copy link
Member Author

obycode commented Apr 19, 2024

Oh, nice. I see that now. I was getting an error from signPoxSignature. It looks like just the period and reward cycle were the problem. Maybe that's intentional though?

@janniks
Copy link
Collaborator

janniks commented Apr 22, 2024

Yeah, those we left as number intentionally, but maybe there's a case they should be bigint.

@smcclellan smcclellan moved this from 🆕 New to 🏗 In Progress in DevTools Apr 22, 2024
@smcclellan smcclellan moved this from 🏗 In Progress to 📋 Backlog in DevTools Apr 22, 2024
@smcclellan smcclellan moved this from 📋 Backlog to 🆕 New in DevTools Apr 22, 2024
@janniks
Copy link
Collaborator

janniks commented Apr 22, 2024

I'll close for now, please reopen if you feel bigint would be better. Realistically it should never be reached/needed, so I hope number is more understandable to be a lower "number" in users' minds -- but who knows :)

@janniks janniks closed this as completed Apr 22, 2024
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in DevTools Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Brand new functionality. New pages, workflows, endpoints, etc.
Projects
Archived in project
Development

No branches or pull requests

2 participants