Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite $step3 on sgl-heading mixins ? #19

Closed
rizqinizamil opened this issue Feb 19, 2018 · 7 comments
Closed

Rewrite $step3 on sgl-heading mixins ? #19

rizqinizamil opened this issue Feb 19, 2018 · 7 comments
Assignees

Comments

@rizqinizamil
Copy link

When I use steps more than 3, let say 5 to 0, I need to re-adjust sgl-heading mixins. Change margin-bottom to 0.
Because when I use step 3 for H3 it will be make more margin bottom.
What do you think?

@hiulit
Copy link
Owner

hiulit commented Feb 20, 2018

I'm sorry, I don't quite understand what you mean when you say:

When I use steps more than 3, let say 5 to 0

You can take a look at the documentation to see how to use sgl-heading().

Take into account that Sassy-Gridlover is a port of Gridlover, so, in principle, Sassy-Gridlover does (or does not) what Gridlover does.

@rizqinizamil
Copy link
Author

Hi, thank you for your reply. I'm sorry took so long to reply back.
Actually I don't use default setting from Gridlover, but Gridlover also let user to change the setting. For example I use step 5 (instead of step 3) for H1
Image of H1

I hope you understand what I mean 😄

@hiulit
Copy link
Owner

hiulit commented Mar 13, 2018

Ok, I see it now, Yes, you are right! I don't have much time right now, but I'll take a look at it whenever I can.
Also, you could send me a Pull Request if you want. :D

@hiulit hiulit self-assigned this Mar 13, 2018
@hiulit
Copy link
Owner

hiulit commented Dec 14, 2018

Just a heads up, I'm working on it. I'll keep you updated ;)

@hiulit
Copy link
Owner

hiulit commented Dec 18, 2018

@rizqinizamil I just published v6.0.0 with the changes ;)

@hiulit hiulit closed this as completed Dec 18, 2018
@rizqinizamil
Copy link
Author

Wow! This is another christmas gift 😄
I'll give it a try! Thank you!

@hiulit
Copy link
Owner

hiulit commented Dec 19, 2018

Yes, please, try it and let me know if it works. In principle, it mimics the same behaviour as Gridlover.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants