Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ServiceMonitor resources for both HiveMQ Platform Operator Helm charts and HiveMQ Platform Helm charts #399

Merged
merged 12 commits into from
Dec 2, 2024

Conversation

afalhambra-hivemq
Copy link
Contributor

@afalhambra-hivemq afalhambra-hivemq commented Nov 27, 2024

https://hivemq.kanbanize.com/ctrl_board/22/cards/27143/details/

Edit: Haven't added the new matrix tags to the branch protection rules, as I would like to get first the approval. Will include that and re-trigger the verify job afterwards.

@afalhambra-hivemq afalhambra-hivemq self-assigned this Nov 27, 2024
@cla-bot cla-bot bot added the cla-signed label Nov 27, 2024
@afalhambra-hivemq afalhambra-hivemq force-pushed the feature/27143-create-service-monitor branch 3 times, most recently from 32bf2e7 to 057b37a Compare November 27, 2024 16:20
@afalhambra-hivemq afalhambra-hivemq force-pushed the feature/27143-create-service-monitor branch from 057b37a to 5ddc721 Compare November 27, 2024 16:58
@afalhambra-hivemq afalhambra-hivemq force-pushed the feature/27143-create-service-monitor branch from 5ddc721 to cefd455 Compare November 28, 2024 12:31
Copy link
Contributor

@mhofsche mhofsche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review of the values.yaml only

charts/hivemq-platform-operator/values.yaml Outdated Show resolved Hide resolved
charts/hivemq-platform-operator/values.yaml Outdated Show resolved Hide resolved
charts/hivemq-platform-operator/values.yaml Outdated Show resolved Hide resolved
charts/hivemq-platform-operator/values.yaml Outdated Show resolved Hide resolved
charts/hivemq-platform-operator/values.yaml Outdated Show resolved Hide resolved
charts/hivemq-platform-operator/values.yaml Outdated Show resolved Hide resolved
charts/hivemq-platform-operator/values.yaml Show resolved Hide resolved
charts/hivemq-platform-operator/values.yaml Outdated Show resolved Hide resolved
@afalhambra-hivemq afalhambra-hivemq force-pushed the feature/27143-create-service-monitor branch 2 times, most recently from 82562b2 to 6562192 Compare November 29, 2024 16:24
@afalhambra-hivemq afalhambra-hivemq force-pushed the feature/27143-create-service-monitor branch 3 times, most recently from e303eed to f0f5b03 Compare December 2, 2024 07:47
@afalhambra-hivemq afalhambra-hivemq force-pushed the feature/27143-create-service-monitor branch from f0f5b03 to 2fe846c Compare December 2, 2024 08:03
Copy link
Contributor

@Donnerbart Donnerbart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an awesome addition to the Helm chart!

@afalhambra-hivemq afalhambra-hivemq merged commit fc43fd1 into develop Dec 2, 2024
39 checks passed
@afalhambra-hivemq afalhambra-hivemq deleted the feature/27143-create-service-monitor branch December 2, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants