-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ServiceMonitor resources for both HiveMQ Platform Operator Helm charts and HiveMQ Platform Helm charts #399
Merged
afalhambra-hivemq
merged 12 commits into
develop
from
feature/27143-create-service-monitor
Dec 2, 2024
Merged
Add ServiceMonitor resources for both HiveMQ Platform Operator Helm charts and HiveMQ Platform Helm charts #399
afalhambra-hivemq
merged 12 commits into
develop
from
feature/27143-create-service-monitor
Dec 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afalhambra-hivemq
force-pushed
the
feature/27143-create-service-monitor
branch
3 times, most recently
from
November 27, 2024 16:20
32bf2e7
to
057b37a
Compare
afalhambra-hivemq
force-pushed
the
feature/27143-create-service-monitor
branch
from
November 27, 2024 16:58
057b37a
to
5ddc721
Compare
afalhambra-hivemq
force-pushed
the
feature/27143-create-service-monitor
branch
from
November 28, 2024 12:31
5ddc721
to
cefd455
Compare
Donnerbart
reviewed
Nov 29, 2024
charts/hivemq-platform-operator/tests/hivemq_operator_deployment_test.yaml
Outdated
Show resolved
Hide resolved
Donnerbart
reviewed
Nov 29, 2024
mhofsche
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
review of the values.yaml only
afalhambra-hivemq
force-pushed
the
feature/27143-create-service-monitor
branch
2 times, most recently
from
November 29, 2024 16:24
82562b2
to
6562192
Compare
afalhambra-hivemq
force-pushed
the
feature/27143-create-service-monitor
branch
3 times, most recently
from
December 2, 2024 07:47
e303eed
to
f0f5b03
Compare
afalhambra-hivemq
force-pushed
the
feature/27143-create-service-monitor
branch
from
December 2, 2024 08:03
f0f5b03
to
2fe846c
Compare
Donnerbart
reviewed
Dec 2, 2024
Donnerbart
reviewed
Dec 2, 2024
charts/hivemq-platform/tests/monitoring/hivemq_service_monitor_test.yaml
Show resolved
Hide resolved
Donnerbart
reviewed
Dec 2, 2024
charts/hivemq-platform/tests/monitoring/hivemq_grafana_dashboard_test.yaml
Outdated
Show resolved
Hide resolved
Donnerbart
approved these changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an awesome addition to the Helm chart!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://hivemq.kanbanize.com/ctrl_board/22/cards/27143/details/
Edit: Haven't added the new matrix tags to the branch protection rules, as I would like to get first the approval. Will include that and re-trigger the
verify
job afterwards.