Password in file includes newline

[jcassee]

When creating a password file, most editors will automatically add a trailing newline. This newline is (apparently) included in the password sent to the server. It would be useful if only the characters up to the first newline were used.

Expected behavior

$ echo PASSWORD > password
$ mqtt sub -t topic -pw:file password --debug
Client 'UNKNOWN@SERVER' sending CONNECT MqttConnect{keepAlive=60, cleanStart=true, sessionExpiryInterval=0, simpleAuth=MqttSimpleAuth{username and password}}                                                                                                  
Client 'UNKNOWN@SERVER' received CONNACK MqttConnAck{reasonCode=SUCCESS, sessionPresent=false, assignedClientIdentifier=auto-69615666-347F-F76C-3185-2E278E94D8A5, restrictions=MqttConnAckRestrictions{receiveMaximum=65535, maximumPacketSize=268435460, topicAliasMaximum=10, maximumQos=EXACTLY_ONCE, retainAvailable=true, wildcardSubscriptionAvailable=true, sharedSubscriptionAvailable=true, subscriptionIdentifiersAvailable=true}} 
[...]

Actual behavior

$ echo PASSWORD > password
$ mqtt sub -t topic -pw:file password --debug
Client 'UNKNOWN@SERVER' sending CONNECT MqttConnect{keepAlive=60, cleanStart=true, sessionExpiryInterval=0, simpleAuth=MqttSimpleAuth{username and password}}
Client 'UNKNOWN@SERVER' DISCONNECTED CONNECT failed as CONNACK contained an Error Code: NOT_AUTHORIZED.
CONNECT failed as CONNACK contained an Error Code: NOT_AUTHORIZED.

$ echo -n PASSWORD > password
$ mqtt sub -t topic -pw:file password --debug
Client 'UNKNOWN@SERVER' sending CONNECT MqttConnect{keepAlive=60, cleanStart=true, sessionExpiryInterval=0, simpleAuth=MqttSimpleAuth{username and password}}                                                                                                  
Client 'UNKNOWN@SERVER' received CONNACK MqttConnAck{reasonCode=SUCCESS, sessionPresent=false, assignedClientIdentifier=auto-69615666-347F-F76C-3185-2E278E94D8A5, restrictions=MqttConnAckRestrictions{receiveMaximum=65535, maximumPacketSize=268435460, topicAliasMaximum=10, maximumQos=EXACTLY_ONCE, retainAvailable=true, wildcardSubscriptionAvailable=true, sharedSubscriptionAvailable=true, subscriptionIdentifiersAvailable=true}} 
[...]

To Reproduce

Steps

1. Create a password file ending in a newline
2. Try to connect to the MQTT server

Reproducer code

Details

• Affected MQTT CLI version(s): 1.1.2
• Used JVM version: 11.0.6 (Ubuntu OpenJDK 64-Bit Server VM 11.0.6+10-post-Ubuntu-1ubuntu119.10.1)

[jcassee]

Thanks, @gitseti!