Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NM-71] Ensure that download result polling is stopped when outputs are reset #1029

Merged
merged 2 commits into from
Nov 19, 2024

Conversation

r-ash
Copy link
Collaborator

@r-ash r-ash commented Nov 18, 2024

Description

We can get into a state where the app will poll the download status without an ID repeatedly. To recreate

  1. Go to the “Save resutls” stage on a project, wait for status poll to begin
  2. Go back to an earlier step and change something which invalidates the later steps e.g. change a model option
  3. See that the app will continue to poll /download/status without an ID

When the download step is invalidated, we should cancel any polling

Type of version change

Patches

Checklist

  • I have incremented version number, or version needs no increment
  • The build passed successfully, or failed because of ADR tests

Copy link
Contributor

@M-Kusumgar M-Kusumgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! happy to approve this for now, i want to test it out but slow internet XD but yh will async run up the app and test

edit: can confirm i dont see the polling

@r-ash r-ash merged commit f17ad84 into main Nov 19, 2024
6 of 9 checks passed
@r-ash r-ash changed the title Ensure that download result polling is stopped when outputs are reset [NM-71] Ensure that download result polling is stopped when outputs are reset Nov 19, 2024
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants