[NM-17] uncertainty ranges in tooltips #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-ash
changed the title
|
I've added a follow up ticket for the sample size https://www.notion.so/unaids-naomi/Add-sample-size-into-input-tooltips-143a29ab93b580f6a011edf7071fb9b0?pvs=4 |
r-ash
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Links to mrc-ide/naomi#451 where i add
ci_upperandci_lowerin the metadata, i think i will split the ticket into two and do sample size after some discussion with rachel, we can get this in main in the meantimereview the naomi pr first but the test failures specific to ubuntu seem like some packages are throwing warnings only on ubuntu and causing tests to fail, can i leave that to another ticket as well? would be good to get this simple thing in and then focus on that later when we have more time
also our tooltip stuff wasnt actually pulling out from the metadata so pulled it out
ps: test failures for backend and browser tests are in main too