Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NM-76] Update test data #1033

Merged
merged 6 commits into from
Nov 20, 2024
Merged

[NM-76] Update test data #1033

merged 6 commits into from
Nov 20, 2024

Conversation

r-ash
Copy link
Collaborator

@r-ash r-ash commented Nov 19, 2024 •
edited
Loading

Description

Jeff has updated the test data, this PR goes through and updates that and its uses in tests

In screenshots should see

  • Date change
  • More data points in output plots
  • Only 1 survey selected (2 previously)

Type of version change

None

Checklist

  • I have incremented version number, or version needs no increment
  • The build passed successfully, or failed because of ADR tests

@notion-workspace Notion Workspace
Copy link

Update Malawi test data in ADR and hint

@r-ash
Copy link
Collaborator Author

r-ash commented Nov 19, 2024

/update-snapshots

@r-ash r-ash requested a review from M-Kusumgar November 19, 2024 15:07
M-Kusumgar
M-Kusumgar approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@M-Kusumgar M-Kusumgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, had a look at the adr test failures, assuming that is on the ADR end of things

@r-ash r-ash merged commit c9dd95c into main Nov 20, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@M-Kusumgar M-Kusumgar M-Kusumgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r-ash @M-Kusumgar