[NM-84] Remove AGYW #1037
Merged
[NM-84] Remove AGYW #1037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
M-Kusumgar
commented
Nov 20, 2024
| @@ -1,12 +1,10 @@ | |||
| const urlParams = new URLSearchParams(window.location.search); | |||
| const urlParams = new URLSearchParams(globalThis.location?.search); | |||
There was a problem hiding this comment.
playwright now loads this code because we import in the DownloadType into a playwright file, however it runs in a "node" environment not a browser env which means theres no window object. globalThis object is just the global this object so in a browser it is window and in a "node" env its just the global object, which means we can use this with playwright
There was a problem hiding this comment.
(Can you stick that in a comment above, I'll definitely forget about this)
r-ash
approved these changes
Nov 21, 2024
| @@ -1,12 +1,10 @@ | |||
| const urlParams = new URLSearchParams(window.location.search); | |||
| const urlParams = new URLSearchParams(globalThis.location?.search); | |||
There was a problem hiding this comment.
(Can you stick that in a comment above, I'll definitely forget about this)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
this was a bigger diff because AGYW has a switch associated with it and also it doesnt have adr metadata support which means i had to put some if statements with it, but the diff would be even smaller when we remove buttons.
to test out how easy adding a button is (given the adr endpoint) you can just add a new value to the enum and follow the typescript errors, for the
urlin thedownloadPostConfigyou can just write one of the existing ones like"coarse-output", it should be about 6 lines of change (3 indownloadConfig.tsand 3 in locals if you want all the translations) to add a fully working new button