Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NM-93] Add cascade plot #1040

Merged
merged 6 commits into from
Nov 28, 2024
Merged

[NM-93] Add cascade plot #1040

merged 6 commits into from
Nov 28, 2024

Conversation

r-ash
Copy link
Collaborator

@r-ash r-ash commented Nov 26, 2024

Description

We want to add a cascade plot into the app. Cascade plot shows 95-95-95 targets (95% of people living with HIV are aware of the status, 95% of those aware are on treatment and 95% of those on treatment are virally suppressed)

At the moment we don't have viral suppression data from the model, but this shows the first 3 bars of the cascade. In the future we'd also like to add this as a plot of proportions instead of just pure counts.

Type of version change

Minor

Checklist

  • I have incremented version number, or version needs no increment
  • The build passed successfully, or failed because of ADR tests

@r-ash
Copy link
Collaborator Author

r-ash commented Nov 26, 2024

/update-snapshots

@r-ash r-ash changed the title Add cascade plot [NM-93] Add cascade plot Nov 26, 2024
Copy link

@krisdoyon
Copy link
Contributor

Noticed something when playing with the filters running locally and wondering if this is expected behavior or not: If you have area level set to country, then drill down into the area filter and turn off a single district (or any other sub-level), you get the no data available message. Should user be able to show some subset of data at the country level for example, or is this working as intended?

@r-ash
Copy link
Collaborator Author

r-ash commented Nov 27, 2024

Noticed something when playing with the filters running locally and wondering if this is expected behavior or not: If you have area level set to country, then drill down into the area filter and turn off a single district (or any other sub-level), you get the no data available message. Should user be able to show some subset of data at the country level for example, or is this working as intended?

Yes working as intended, but I do agree it is not the best behaviour. So this is the same also as how we do it in the Choropleth, you'll similar get a no data message. We've talked about addressing this before by greying out options in the drop down which would lead to no data being shown. But we've never got around to it, I think it will be quite fiddly to implement and I am not super convinced having greyed out options is much better.

So something to address across all plots down the line I think. Let me know if you have any good ideas of how we can make this a bit of a nicer user experience.

@r-ash
Copy link
Collaborator Author

r-ash commented Nov 27, 2024

/update-snapshots

@r-ash r-ash merged commit 1c54703 into main Nov 28, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants