Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CheckOCSP does not return OCSPStaple #182

Closed
nhooyr opened this issue Jul 21, 2016 · 2 comments
Closed

CheckOCSP does not return OCSPStaple #182

nhooyr opened this issue Jul 21, 2016 · 2 comments

Comments

@nhooyr
Copy link

nhooyr commented Jul 21, 2016

CheckOCSP does not return the the actual byte response from the server so it cannot be used for ocsp stapling.

See how lego does it here

It returns both the byte response and the parsed OCSP response.

btw is there any reason acmeapi prefers to use http get over post to request the OCSP response? (I dont know which is better, just wondering if there is any thought behind the decision)

@hlandau
Copy link
Owner

hlandau commented Aug 5, 2016

GET is probably preferred for retrieving OCSP responses nowadays since it makes it easier for CDNs to cache them like any other HTTP request.

Looking into this.

@hlandau
Copy link
Owner

hlandau commented Aug 5, 2016

Added CheckOCSPRaw method.

@hlandau hlandau closed this as completed in 85bd96e Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants