Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to display full day event #132

Closed
rdewolff opened this issue Aug 30, 2021 · 8 comments · Fixed by #306
Closed

Add ability to display full day event #132

rdewolff opened this issue Aug 30, 2021 · 8 comments · Fixed by #306
Labels
status: in progress type: feature enhancements or new features

Comments

@rdewolff
Copy link

As a user, I wish to see full day events on the top of my day in a dedicated space, to avoid filling too much space in the week view.

This is usually an allDay Boolean in the event object to decide if this event should be displayed differently.

Cf info https://github.com/wmcmahan/react-native-calendar-events#event-fields

2C093857-A005-46F8-AE5A-29832589E339

@pdpino pdpino added the type: feature enhancements or new features label Aug 30, 2021
@rdewolff
Copy link
Author

What do you guys think about this addition?

@pdpino
Copy link
Collaborator

pdpino commented Aug 31, 2021

I think this feature is broad enough for the library, it would be nice to implement it.
But it would take some time. Some considerations:

  • The all-day events behave somewhat different from regular events:
    • cannot be dragged, at least not vertically (upcoming feature)
    • endHour cannot be edited by long-pressing (upcoming feature)
  • The dedicated-space height should grow according to the amount of all-day events
  • When scrolling horizontally, the dedicated-space height may change in different weeks --> should be smoothly animated (ideally)

@rdewolff
Copy link
Author

rdewolff commented Sep 14, 2021

Yeah this is an important feature for any calendar. Hope we can have this soon 👍

@pdpino pdpino added the status: on hold Not addressed yet or waiting other issue label Apr 25, 2022
@TheTushar2696
Copy link

@pdpino any plans to pick this up in the near future?

@pdpino
Copy link
Collaborator

pdpino commented Jul 28, 2022

Yes sure, I will consider it in the upcoming features

@rdewolff
Copy link
Author

Looking forward having this too!

@pdpino pdpino added status: in progress and removed status: on hold Not addressed yet or waiting other issue labels Aug 17, 2022
@pdpino
Copy link
Collaborator

pdpino commented Sep 2, 2022

I have a first version for this feature:

v0-2022-09-02_10.16.14.mp4

I will send a PR after block-events #220 though (to avoid merge conflicts)

@rdewolff
Copy link
Author

bump :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: in progress type: feature enhancements or new features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants