-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
description unreadable with short duration events #50
Comments
Don't know if is the best idea, but you could use the const MyComponent = ({ event, position }) => (
<Text style={{ fontSize: calculateFontSize(position.height), ...otherStyles }}>
{event.description}
</Text>
) In UPDATE: You could try a simpler solution: pass the prop |
This is because the events are overlapped, i.e. the second event starts at the same time or before the first event ends (measured in milliseconds). A possible solution is to change the I had a similar problem and applied a hacky solution (in my fork): I added an |
This is the purpose of the |
@pdpino about the events in sequence issue, I agree that the width of event items should be full width of the column. But can we just have a constant for it? |
@hoangnm do you mean not passing as prop? something like |
Nice, I encountered the same problem, when will the changes be integrated on the master ? |
@RimApp which of the problems described here? the (1) description unreadable with short events or (2) events in sequence overlapping? For (1), you should be able to apply any of the fixes described in the comment above. If that does not work for you, please let me know. For (2), the changes are already merged to master (PR #53), and incorporated in version 0.1.1. Events that are overlapped by less than 2 seconds should not get shrinked in width. Again, if you have any issues with this let me know 🙂 |
it works perfectly on the master branch. |
My bad, it's work perfectly :) |
@hoangnm I think u can close this issue? |
yes, thanks for your help @pdpino ! |
Any recommendations for a workaround?
Thanks
The text was updated successfully, but these errors were encountered: