Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: use country flags instead of colored circles in legends #88

Closed
ivan-aksamentov opened this issue Feb 8, 2021 · 1 comment · May be fixed by #135
Closed

Idea: use country flags instead of colored circles in legends #88

ivan-aksamentov opened this issue Feb 8, 2021 · 1 comment · May be fixed by #135
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@ivan-aksamentov
Copy link
Collaborator

ivan-aksamentov commented Feb 8, 2021

Related: #81 #87

The idea is to use country flag icons instead of colored circles on "Per country" page for plot headings and filtering sidebar.

Originally, the country colors were meant for line plots in "Per variant" page, and they have no significance for the "Per country" page. But it was making sense to also use the same colors in country icons to connect the two pages together.

Now that there are more countries added, some colors started to be duplicated. On "Per variant" page the logical solution was to reuse the line styles to make the countries visually distinct #87. However, it might be confusing to use the same kind of line icons on "Per country" page, which does not have line plots.

This should solve the problem of duplicated colors on "Per country" page.

@ivan-aksamentov ivan-aksamentov added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers needs triage Pending maintainers' attention and removed needs triage Pending maintainers' attention labels Feb 8, 2021
@emmahodcroft
Copy link
Collaborator

I agree with you Ivan, that this makes more sense than the colours! I'd be happy if this implemented, though I'd say it's not high priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants