Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the best of the values from all the sources #5

Open
hoijui opened this issue Oct 11, 2021 · 0 comments
Open

Use the best of the values from all the sources #5

hoijui opened this issue Oct 11, 2021 · 0 comments

Comments

@hoijui
Copy link
Owner

hoijui commented Oct 11, 2021

As it is now, it simply uses the last gathered value, which is the one from the source with the highest hierarchy/level.
We should validate all gathered values, and choose the best one according to the validation result, or the last gathered one, if there are multiple best ones.

NOTE: For this we also want to have differently graded sub-optimal values (yet to be implemented). Think for example of the Version property, where "0.1.0-12-g37f98ea" should be better then "37f98ea" alone, even though both are not optimal.
... or in this case, we should maybe make the first one optimal, as we do not want "0.1.0" to be preferred over "0.1.0-12-g37f98ea", as it is most likely less accurate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant