Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UseSLF4JLoggerRule #1

Merged
merged 1 commit into from
Mar 1, 2024
Merged

Fix UseSLF4JLoggerRule #1

merged 1 commit into from
Mar 1, 2024

Conversation

wborn
Copy link

@wborn wborn commented Mar 1, 2024

This seems to the UseSLF4JLoggerRule for me. WDYT?

@wborn wborn mentioned this pull request Mar 1, 2024
Merged
@wborn
Fix UseSLF4JLoggerRule
2e254de 
Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn force-pushed the fix-UseSLF4JLoggerRule branch from e12b333 to 2e254de Compare March 1, 2024 19:17
@holgerfriedrich holgerfriedrich merged commit 00b8771 into holgerfriedrich:pr-pmd7 Mar 1, 2024
@holgerfriedrich
Copy link
Owner

Thanks, @wborn !
Looks goot to me. You found the way to combine getSimpleName() with getPackageName(). I was till stuck at getOriginalText(), which is not exactly what I wanted.

@wborn wborn deleted the fix-UseSLF4JLoggerRule branch March 1, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wborn @holgerfriedrich