Remove old stacktrie #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix a few bugs * Fix the remaining bugs * Move the stack code to its own file * More PR grooming
* Base algorithm * Pass the initial tests * Works with all available tests * Fix missing headers * Various fixes after rebase * Fix issue coming out of goerli sync * Code cleanup and documentation * More comments * Remove outdated tests * Compare StdGenerate with ReStackTrie * Fix the benchmark tests (#11)
* revert snaphash to processing all accounts * use ReStackTrie in generateTrie * Save memory by hashing a branch if no more insert will occur
* revert snaphash to processing all accounts * use ReStackTrie in generateTrie * Save memory by hashing a branch if no more insert will occur * Don't create unnecessary common.Hash objects
* fix issues when using storage trie * bugfix: 0 as first key byte would produce invalid results
gballet
force-pushed
the
remove-old-stacktrie
branch
from
e44e12f
to
5dc6214
Compare
holiman
pushed a commit
that referenced
this pull request
Nov 26, 2022
* Add running blob txs count to block header - and update the blob fee rules to the full version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StackTriewas a nice experiment and I was keeping it around to remember some of the optimization tricks that I put in there. It is also very buggy and has since then been superseded byReStackTrie.This PR also include a bugfix that was dropped from the previous bugfix PR.