Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployments to internal branches should not invalidate CloudFront cache #500

Open
forabi opened this issue May 26, 2018 · 1 comment
Open
Assignees
Labels
pending: dependency issue performance repo: hollowverse Issues related to hollowverse/hollowverse

Comments

@forabi
Copy link
Contributor

forabi commented May 26, 2018

  • It does not make sense to invalidate beta/master caches when we deploy to an internal branch
  • Invalidating cache has no effect on internal branches because they are not cached in the first place.
@forabi forabi self-assigned this May 26, 2018
@forabi forabi added repo: hollowverse Issues related to hollowverse/hollowverse performance labels May 26, 2018
@forabi
Copy link
Contributor Author

forabi commented Jul 16, 2018

Pending progress on aghadiry/serverless-cloudfront-invalidate#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending: dependency issue performance repo: hollowverse Issues related to hollowverse/hollowverse
Projects
None yet
Development

No branches or pull requests

1 participant