Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce ESLint for TypeScript files on CI #524

Closed
forabi opened this issue Jun 12, 2018 · 1 comment
Closed

Enforce ESLint for TypeScript files on CI #524

forabi opened this issue Jun 12, 2018 · 1 comment
Labels
dx Issues that affect developer experience

Comments

@forabi
Copy link
Contributor

forabi commented Jun 12, 2018 •
edited
Loading

For the past month we have had ESLint enabled for TypeScript files in VS Code but we didn't enforce it on CI because I wanted to test how well it worked. There seems to be a few parsing bugs but I think we should be able to enforce it.

It's already enabled for hollowverse/hollowverse but not for the other repos.
@forabi forabi added the dx Issues that affect developer experience label Jun 12, 2018
@forabi
Copy link
Contributor Author

forabi commented Jun 27, 2018

Done in hollowverse-archive/api#98 hollowverse-archive/route-request#32 hollowverse-archive/track-performance#60 hollowverse-archive/process-image#17 hollowverse-archive/config#92 hollowverse-archive/config#91

@forabi forabi closed this as completed Jun 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dx Issues that affect developer experience
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@forabi