Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ws port config for custom bundles #58

Open
nphias opened this issue Feb 13, 2020 · 2 comments
Open

ws port config for custom bundles #58

nphias opened this issue Feb 13, 2020 · 2 comments

Comments

@nphias
Copy link

nphias commented Feb 13, 2020

so after adding our bundle to holoscape throught the UI wizard
realized the links were hardcoded to a WS port.
in the docs
HOLOSCAPE_ADMIN_PORT 4436

changed the static files ws port to 4436 and it worked.
in the bundle config file it would be nice if you could choose the websocket port for your happ
later I realized that one can change the port in the condutor_config.toml in the relevant OS install directory. Its a post install task... which could be documented better

so i keep this issue open for a potential pre-install feature or for clearer documentation post install

@nphias nphias mentioned this issue Feb 13, 2020
@marcusnewton
Copy link

This can be fixed by removing the websocket url argument from hc-web-client. When you remove that argument, hc-web-client looks for the port specified in conductor-config.toml instead.

@Connoropolous
Copy link
Collaborator

I also find this is an under-documented thing.

Our acorn-ui project uses this configuration, where our webpack config adds a NODE_ENV distinction between 'development' and 'production' so that we can pass the right thing to our connect call, from hc-web-client.
See: https://github.com/h-be/acorn-ui/blob/78006146562a4816a9a93f0119e3b7e5b15bce0c/src/index.js#L34-L40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants