Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unless making this .on instead of .once all the conductor logs are swallowed here #124

Closed
Connoropolous opened this issue Jun 16, 2022 · 7 comments · Fixed by #125
Closed
Labels
bug Something isn't working

Comments

@Connoropolous
Copy link
Contributor

runConductorProcess.stderr.once("data", (data: Buffer) => {
logger.error(`starting conductor: ${data.toString()}`);
});

@Connoropolous
Copy link
Contributor Author

I also changed it to logger.info . Preferable of course would be an upstream fix of some kind to route things not through stderr. I'm not sure why they're coming here

@jost-s jost-s added the bug Something isn't working label Jun 16, 2022
@jost-s
Copy link
Contributor

jost-s commented Jun 16, 2022

Thanks for spotting that, @Connoropolous. I agree to it all and also have no idea why it comes out on stderr.
I'll release a fix promptly.

@jost-s
Copy link
Contributor

jost-s commented Jun 16, 2022

This looks right https://github.com/holochain/holochain/blob/develop/crates/hc_sandbox/src/run.rs#L99

So perhaps it's further up in the holochain command.

@abe-njama I'll add this to the backlog.

@jost-s
Copy link
Contributor

jost-s commented Jun 16, 2022

actually wait, please post an example of an info log that appears as an error, @Connoropolous

@Connoropolous
Copy link
Contributor Author

sure yes. I made the text prefix for stderr "conductor log" and used "logger.info"
Here's one:

18:55:21 [Tryorama - Local Conductor] info: conductor log: Jun 15 18:55:21.452  INFO kitsune_p2p_types::metrics: sys_info=MetricSysInfo { used_mem_kb: 1596555, proc_cpu_usage_pct_1000: 24463, tx_bytes_per_sec: 409, rx_bytes_per_sec: 1843, sends_per_sec: 0, recvs_per_sec: 0, tokio_task_count: 7, avg_pool_buf_release_size: 0, avg_api_req_res_elapsed_ms: 0 }

@jost-s
Copy link
Contributor

jost-s commented Jun 16, 2022

Great, I'll add that to the backlog issue and change the log to logger.info in the meanwhile/for the time being.

@Connoropolous
Copy link
Contributor Author

groovy, thanks @jost-s. You are on it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants