-
-
Notifications
You must be signed in to change notification settings - Fork 402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xextents of overlay of raster and HLine #1079
Comments
Definitely seems to be a bug. Thanks for reporting this. |
It seems the HLine and VLine plots classes have never implemented a custom |
Actually had we not decided that certain annotations should not be considered when computing the bounds? If that regressed then that would explain why we hadn't noticed this before. |
We did discuss it before but I can't remember what we decided. Personally I would quite like for annotations to be included in the bounds calculation but there could be a good reason not to. I don't mind either way as long as we are consistent. |
There is certainly an argument for not considering line annotations when computing the bounds (though of course it would need to be both types of such annotations). E.g. one may want to provide a red line to mark a danger threshold, and as long as that threshold is never reached, there's no reason to enlarge the display to include it. But there are also other cases when one might want to include the location of the annotation, so maybe there should be a configuration option to determine whether annotations affect the extents. |
When drawing a line outside the extents of an Raster/Image, the extents of the overlay grow such that the line is also visible.
Works for VLine
hv.Raster(np.random.rand(100,100))*hv.VLine(x=120)
Does not work for HLine: xaxis extended instead of yaxis
hv.Raster(np.random.rand(100,100))*hv.HLine(y=120)
The text was updated successfully, but these errors were encountered: