Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression with Sankey plot #4330

Closed
harmbuisman opened this issue Mar 28, 2020 · 0 comments · Fixed by #4337
Closed

Regression with Sankey plot #4330

harmbuisman opened this issue Mar 28, 2020 · 0 comments · Fixed by #4337
Labels
type: bug Something isn't correct or isn't working
Milestone

Comments

@harmbuisman
Copy link
Contributor

ALL software version info

Holoviews: 0.13.1
Python: 3.7
Bokeh: 2.0

Description of expected behavior and the observed behavior

Regression with a sankey plot case that was working in 0.12

Case now leads to a ZeroDivisionError.

Complete, minimal, self-contained example code that reproduces the issue

empty = pd.DataFrame({'source':['No data'], 'target':[' No data'], 'count':[1]})
sankey = hv.Sankey(empty)

Stack traceback and/or browser JavaScript console output

215             max_depth = max(depths.values()) - 1 if depths else 1
216             height = self.p.bounds[3] - self.p.bounds[1]

--> 217 py = min((height * 0.1) / max_depth, 20)
218
219 def initializeNodeBreadth():

ZeroDivisionError: float division by zero

Screenshots or screencasts of the bug in action

Expected result which is given by 0.12.7:
image

@philippjfr philippjfr added the type: bug Something isn't correct or isn't working label Mar 28, 2020
@philippjfr philippjfr added this to the v1.13.2 milestone Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants