Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strange rasterize colormapping in Large Data user guide #4635

Closed
jlstevens opened this issue Sep 28, 2020 · 3 comments · Fixed by #4693
Closed

Strange rasterize colormapping in Large Data user guide #4635

jlstevens opened this issue Sep 28, 2020 · 3 comments · Fixed by #4693
Labels
type: bug Something isn't correct or isn't working
Milestone

Comments

@jlstevens
Copy link
Contributor

While discussing #4567 with @jbednar, we noticed the following strange output in the Large Data User Guide

image

This looks pretty strange as it looks like the reverse of the fire colormap where black is low and white is high as the raster holds positive counts with higher counts in the middle:

Initially I thought this might be related to the recent work in #4567 but then realized that it can't be as that PR hasn't been merged yet.

Presumably it used to look like the GIF shown for the next code cell (i.e normal fire with a black background)?

@jlstevens jlstevens added the TRIAGE Needs triaging label Sep 28, 2020
@jlstevens
Copy link
Contributor Author

@philippjfr did say this was rather strange. As it is important to address, I'll assign it to the next milestone.

@jlstevens jlstevens added type: bug Something isn't correct or isn't working and removed TRIAGE Needs triaging labels Oct 5, 2020
@jlstevens jlstevens added this to the v1.13.4 milestone Oct 5, 2020
@jlstevens
Copy link
Contributor Author

jlstevens commented Nov 20, 2020

I've tracked this down and it looks like the fire colormap is currently inverted from what it should be:

image

whereas 'fire_r' looks like 'fire':

image

This can't always have been wrong as the GIF above that is part of the notebook shows fire correctly. I have no idea how this happened but we should try to track it down as it is concerning.

@jlstevens
Copy link
Contributor Author

jlstevens commented Nov 20, 2020

Adding hv.opts.defaults(hv.opts.Image(cmap='fire_r')) to the top of the Large Data user guide 'fixes' this issue but doesn't explain why fire is reversed from what it should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants