Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing DynamicMaps #498

Closed
jlstevens opened this issue Feb 10, 2016 · 4 comments
Closed

Testing DynamicMaps #498

jlstevens opened this issue Feb 10, 2016 · 4 comments
Labels

Comments

@jlstevens
Copy link
Contributor

This includes testing the DynamicMap tutorial which needs reference data.

The general issue is that DynamicMaps tend to be empty, leaving nothing to test. And to generate data, you need a live server making the issue even more complicated...

@philippjfr
Copy link
Member

Anything else we want here? We now have a fair number of unit tests.

@jlstevens
Copy link
Contributor Author

We now have a fair number of unit tests.

True but that isn't the same as testing dynamic maps in the notebook. I'm still not sure what we can do about this, or whether there is anything sane we can do about this...

@philippjfr
Copy link
Member

Not sure what "testing dynamic maps in the notebook" adds over unit tests or were you talking about testing the widget code with DynamicMaps? Otherwise they don't behave any differently in a notebook and a unit test so I don't see what notebook tests would add.

@jlstevens
Copy link
Contributor Author

Otherwise they don't behave any differently in a notebook and a unit test so I don't see what notebook tests would add.

Unless we mirror the code in the notebooks against the unit tests (painful!) we have no way of knowing whether the dynamicmaps in the notebooks are behaving properly. That said, I don't mind seeing this issue closed as 'wontfix' as I think the problem is too difficult to solve properly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants