Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overlaying DynamicMaps with different values in same dimension bug #920

Closed
basnijholt opened this issue Oct 10, 2016 · 4 comments
Closed
Assignees
Labels
type: bug Something isn't correct or isn't working
Milestone

Comments

@basnijholt
Copy link
Contributor

basnijholt commented Oct 10, 2016

dm1 = hv.DynamicMap(lambda x, y: hv.Curve(np.random.rand(10)), kdims=[hv.Dimension('x', values=[0, 1]), hv.Dimension('y', values=[0, 1])])
dm2 = hv.DynamicMap(lambda x, y: hv.Curve(np.random.rand(10)), kdims=[hv.Dimension('x', values=[1, 2]), hv.Dimension('y', values=[0, 1])])
dm2 * dm1

compare with dm1 * dm2

Plots are being generated for x values, even though they don't exist.

@basnijholt
Copy link
Contributor Author

basnijholt commented Oct 10, 2016

To make it a bit more clear, I would expect the same result as:

hv.HoloMap({i: hv.Curve(np.random.rand(10)) for i in [0, 1]}) * hv.HoloMap({i: hv.Curve(np.random.rand(10)) for i in [1, 2]})

@philippjfr
Copy link
Member

Thanks for explaining it. The behavior you describe is what I would expect as well.

@jlstevens jlstevens self-assigned this Oct 10, 2016
@jlstevens
Copy link
Contributor

jlstevens commented Oct 10, 2016

I've assigned myself to this issue. Shouldn't be too hard to fix as I just need to raise an appropriate KeyError in the right place.

@jlstevens jlstevens added this to the v1.7.0 milestone Oct 10, 2016
@philippjfr philippjfr added the type: bug Something isn't correct or isn't working label Oct 11, 2016
@philippjfr
Copy link
Member

This has now been fixed, please reopen if you encounter any issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

No branches or pull requests

3 participants