-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure Range streams and RangeToolLink respect subcoordinate axis range #6256
Conversation
@droumis please test when you get a chance. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6256 +/- ##
==========================================
+ Coverage 88.47% 88.52% +0.04%
==========================================
Files 323 323
Lines 67647 67894 +247
==========================================
+ Hits 59853 60103 +250
+ Misses 7794 7791 -3 ☔ View full report in Codecov by Sentry. |
Looks good! Tested a few different versions, including multiple channel groups, with downsample1d, with wide df common index slice optimization, and with the large data pyramid approach. Screen.Recording.2024-06-05.at.10.56.00.AM.movScreen.Recording.2024-06-05.at.11.01.52.AM.mov |
@ahuang11 Remind me what the issue we encountered in the CZI call yesterday was? |
After zooming in, then zooming out, the curves end up offset from the yticks. |
Ah, yes, thanks! |
Works for me! |
@hoxbro This should be ready to review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is amazing (combined with the hold render changes in #6265. Both for notebook and standalone. video1254322944.mp4 |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This PR handles the previously poorly defined behavior of Range streams and RangeToolLink attached to a subcoordinate axis. Specifically both now pick up the range of the outer subcoordinate axis range rather than one of the inner subcoordinate ranges. The latter case is still something that will be needed in certain cases so that is still a problem to be solved.
Fixes #6010 and #6136