Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No longer internally call .reset_index() #1292

Closed
maximlt opened this issue Mar 5, 2024 · 2 comments · Fixed by #1350
Closed

No longer internally call .reset_index() #1292

maximlt opened this issue Mar 5, 2024 · 2 comments · Fixed by #1350
Assignees
Labels
type: enhancement New feature or request

Comments

@maximlt
Copy link
Member

maximlt commented Mar 5, 2024

HoloViews is going to better support Pandas indexes in holoviz/holoviews#6061 so it doesn't have to internally call .reset_index() when a reference is made to an index column. This change will come with some great performance improvements. hvPlot itself calls in several places .reset_index(). To fully benefit from HoloViews' improvements, hvPlot will have to remove these calls to .reset_index().

@maximlt
Copy link
Member Author

maximlt commented Jul 2, 2024

@droumis
Copy link
Member

droumis commented Jul 30, 2024

Closed by #1350

@droumis droumis closed this as completed Jul 30, 2024
@droumis droumis moved this from Todo to idea in CZI R5 neuro Jul 30, 2024
@droumis droumis moved this from idea to Done in CZI R5 neuro Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants