Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Jupyter server extension to serve files #1982

Merged
merged 3 commits into from
Feb 17, 2021
Merged

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Feb 16, 2021

In a Bokeh server context we serve the panel/dist directory on an endpoint, which makes it possible to load all bundled resources from there, while in the notebook we have to rely on either inlining the resources or loading it from CDN. This PR adds a server extension to Panel, which serves the panel/dist directory under a /panel_dist/ endpoint in Jupyter.

@codecov
Copy link

codecov bot commented Feb 16, 2021

Codecov Report

Merging #1982 (d428554) into master (612ca40) will decrease coverage by 0.03%.
The diff coverage is 27.27%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1982      +/-   ##
==========================================
- Coverage   84.87%   84.84%   -0.04%     
==========================================
  Files         157      158       +1     
  Lines       19360    19369       +9     
==========================================
+ Hits        16432    16433       +1     
- Misses       2928     2936       +8     
Impacted Files Coverage Δ
panel/io/jupyter_server_extension.py 0.00% <0.00%> (ø)
setup.py 0.00% <ø> (ø)
panel/io/notebook.py 57.29% <50.00%> (-0.08%) ⬇️
panel/__init__.py 100.00% <100.00%> (ø)
panel/io/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 612ca40...d428554. Read the comment docs.

@philippjfr philippjfr merged commit f0f9b39 into master Feb 17, 2021
@philippjfr philippjfr deleted the server_extension branch February 17, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants