Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] use idom.config to set dist dir #2117

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

rmorshea
Copy link
Contributor

@rmorshea rmorshea commented Mar 25, 2021

See reactive-python/reactpy#320 for more context on this change.

Closes: #2058

@codecov
Copy link

codecov bot commented Mar 25, 2021

Codecov Report

Merging #2117 (bfff8d2) into master (e226a20) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2117   +/-   ##
=======================================
  Coverage   84.42%   84.42%           
=======================================
  Files         180      181    +1     
  Lines       21143    21152    +9     
=======================================
+ Hits        17849    17858    +9     
  Misses       3294     3294           
Impacted Files Coverage Δ
panel/pane/idom.py 46.28% <0.00%> (-0.39%) ⬇️
panel/tests/pane/test_media.py 100.00% <0.00%> (ø)
panel/pane/media.py 72.28% <0.00%> (+1.91%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e226a20...bfff8d2. Read the comment docs.

@rmorshea rmorshea changed the title use idom.config to set dist dir [WIP] use idom.config to set dist dir Mar 25, 2021
@rmorshea
Copy link
Contributor Author

Marking as WIP for right now. I'm still straightening some stuff out at the moment in idom

@philippjfr
Copy link
Member

Thanks @rmorshea!

@philippjfr philippjfr merged commit a3a71ac into holoviz:master Mar 26, 2021
@rmorshea
Copy link
Contributor Author

@philippjfr there's actually some more follow up work. Will create another PR for that though.

@philippjfr
Copy link
Member

Thanks again @rmorshea and sorry for the premature merge.

@rmorshea
Copy link
Contributor Author

No worries

philippjfr pushed a commit that referenced this pull request Apr 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Planned Breaking Changes in IDOM
2 participants