Refactor handling of Plotly updates #2251
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactors the Plotly pane a little bit and ensures that JS events trigger updates to plot.
Part of the problem here is that all property updates are handled via the same update path so to avoid running this multiple times the actual rendering is triggered by a change to the
_render_count
. However a user triggering updates manually, e.g. via JS will not know to increment the render count. Therefore we set a timeout that ensures that if_render_count
hasn't been incremented within 250 ms of the an update to one of the properties then it is incremented automatically.Fixes #2239