Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve request handling for remote pagination on Tabulator #2265

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 29, 2021

Patches ajax requests handling during initialization of the Tabulator so no request is ever sent and ensures Tabulator initialized with None works when paginated.

@codecov
Copy link

codecov bot commented Apr 29, 2021

Codecov Report

Merging #2265 (202daa5) into master (50386e0) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2265      +/-   ##
==========================================
- Coverage   83.64%   83.61%   -0.03%     
==========================================
  Files         183      183              
  Lines       21899    21928      +29     
==========================================
+ Hits        18318    18336      +18     
- Misses       3581     3592      +11     
Impacted Files Coverage Δ
panel/widgets/tables.py 84.07% <100.00%> (ø)
panel/pane/vtk/synchronizable_serializer.py 77.32% <0.00%> (-0.87%) ⬇️
panel/param.py 87.81% <0.00%> (-0.30%) ⬇️
panel/pane/vtk/vtk.py 96.38% <0.00%> (-0.01%) ⬇️
panel/pane/vtk/enums.py 100.00% <0.00%> (ø)
panel/models/vtk.py 98.48% <0.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 50386e0...202daa5. Read the comment docs.

@philippjfr philippjfr merged commit 7d42a99 into master Apr 29, 2021
@philippjfr philippjfr deleted the empty_paginated_tabulator branch April 29, 2021 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant