Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global configuration to always throttle sliders #2306

Merged
merged 5 commits into from
May 17, 2021
Merged

Global configuration to always throttle sliders #2306

merged 5 commits into from
May 17, 2021

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented May 11, 2021

closes #2295

Todo:

  • If the implementation is correct or another implementation is needed.
  • If config.throttled is the correct/best name for the configuration.
  • Add unit test
  • Update documentation
  • Other?

@codecov
Copy link

codecov bot commented May 11, 2021

Codecov Report

Merging #2306 (e2a7855) into master (078c8b2) will increase coverage by 0.42%.
The diff coverage is 96.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2306      +/-   ##
==========================================
+ Coverage   83.68%   84.10%   +0.42%     
==========================================
  Files         183      181       -2     
  Lines       22018    22064      +46     
==========================================
+ Hits        18425    18557     +132     
+ Misses       3593     3507      -86     
Impacted Files Coverage Δ
panel/widgets/slider.py 75.18% <71.42%> (-0.32%) ⬇️
panel/config.py 51.92% <100.00%> (+0.14%) ⬆️
panel/tests/widgets/test_input.py 100.00% <100.00%> (ø)
panel/tests/widgets/test_slider.py 100.00% <100.00%> (ø)
panel/widgets/input.py 96.74% <100.00%> (+0.32%) ⬆️
...nel/tests/template/fast/test_fast_list_template.py 87.50% <0.00%> (-6.25%) ⬇️
panel/tests/template/test_vanilla_manual.py 86.95% <0.00%> (-2.41%) ⬇️
...nel/tests/template/fast/test_fast_grid_template.py 95.83% <0.00%> (-2.09%) ⬇️
panel/tests/template/test_manual.py 61.61% <0.00%> (-1.39%) ⬇️
panel/reactive.py 76.34% <0.00%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 078c8b2...e2a7855. Read the comment docs.

@philippjfr
Copy link
Member

Thanks, I'm happy with this.

@philippjfr philippjfr merged commit 73a3191 into holoviz:master May 17, 2021
@hoxbro hoxbro deleted the config_throttled branch May 17, 2021 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add global configuration to always throttle sliders
2 participants