Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve rendering of ReactiveHTML literal children #2383

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

philippjfr
Copy link
Member

Children which are declared as literals are now synced via the DataModel and no longer trigger a full rerender.

@codecov
Copy link

codecov bot commented Jun 14, 2021

Codecov Report

Merging #2383 (6df7ac0) into master (02ea38b) will decrease coverage by 0.31%.
The diff coverage is 78.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2383      +/-   ##
==========================================
- Coverage   83.55%   83.24%   -0.32%     
==========================================
  Files         185      185              
  Lines       22529    22098     -431     
==========================================
- Hits        18825    18396     -429     
+ Misses       3704     3702       -2     
Impacted Files Coverage Δ
panel/reactive.py 76.11% <73.33%> (-0.25%) ⬇️
panel/models/reactive_html.py 80.53% <100.00%> (+0.13%) ⬆️
panel/auth.py 36.21% <0.00%> (-3.30%) ⬇️
panel/config.py 56.12% <0.00%> (-3.07%) ⬇️
panel/pane/ipywidget.py 47.05% <0.00%> (-2.95%) ⬇️
panel/io/reload.py 63.95% <0.00%> (-2.72%) ⬇️
panel/tests/template/test_manual.py 59.13% <0.00%> (-2.48%) ⬇️
panel/pane/plot.py 55.61% <0.00%> (-2.14%) ⬇️
panel/io/state.py 61.05% <0.00%> (-2.14%) ⬇️
panel/pane/streamz.py 65.71% <0.00%> (-1.86%) ⬇️
... and 89 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02ea38b...6df7ac0. Read the comment docs.

@philippjfr philippjfr merged commit 23dc729 into master Jun 14, 2021
@philippjfr philippjfr deleted the reactive_literals branch June 14, 2021 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant