Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ReactiveHTML correctly interfaces with managed layouts #2402

Merged
merged 3 commits into from
Jun 17, 2021

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Jun 17, 2021

  • Do not compute managed layout unless your parent is a managed layout
  • Do not set managed layout position unless your parent is a managed layout
  • Error if any tag in the template is unclosed

@codecov
Copy link

codecov bot commented Jun 17, 2021

Codecov Report

Merging #2402 (38f48b9) into master (3eb9a63) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2402      +/-   ##
==========================================
- Coverage   83.45%   83.45%   -0.01%     
==========================================
  Files         185      185              
  Lines       22678    22680       +2     
==========================================
+ Hits        18927    18928       +1     
- Misses       3751     3752       +1     
Impacted Files Coverage Δ
panel/reactive.py 74.96% <50.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3eb9a63...38f48b9. Read the comment docs.

@philippjfr philippjfr merged commit 31dec16 into master Jun 17, 2021
@philippjfr philippjfr deleted the reactive_managedd branch June 17, 2021 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant