Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent theme for JSON pane and Code Editor #7394

Closed
MarcSkovMadsen opened this issue Oct 14, 2024 · 0 comments · Fixed by #7406
Closed

Consistent theme for JSON pane and Code Editor #7394

MarcSkovMadsen opened this issue Oct 14, 2024 · 0 comments · Fixed by #7406
Assignees
Labels
type: enhancement Minor feature or improvement to an existing feature
Milestone

Comments

@MarcSkovMadsen
Copy link
Collaborator

MarcSkovMadsen commented Oct 14, 2024

(I plan to make a PR to fix this)

I'm on the main branch of Panel. I was developing a Panel Mermaid Diagram Editor using the JSON pane and CodeEditor widget and I experienced the friction that the theme of these two widget where not aligned and did not automatically adapt to pn.config.theme.

I believe the components should have a light theme if the overall theme is default. And a Black theme otherwise. I think the default themes should be user configurable.

Please support this

Minimum Reproducible Example

import panel as pn

pn.extension("codeeditor")

pn.template.FastListTemplate(
    main=[pn.widgets.CodeEditor(), pn.pane.JSON({"a": 1, "b": 2})]
).servable()

Default

image

Dark

image

@MarcSkovMadsen MarcSkovMadsen added TRIAGE Default label for untriaged issues type: enhancement Minor feature or improvement to an existing feature and removed TRIAGE Default label for untriaged issues labels Oct 14, 2024
@MarcSkovMadsen MarcSkovMadsen added this to the Wishlist milestone Oct 14, 2024
@MarcSkovMadsen MarcSkovMadsen self-assigned this Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant