Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homebridge-tuya #264

Closed
iRayanKhan opened this issue Mar 3, 2021 · 16 comments
Closed

homebridge-tuya #264

iRayanKhan opened this issue Mar 3, 2021 · 16 comments
Labels
verified use when a plugin meets the criteria - adds the verified badge text

Comments

@iRayanKhan
Copy link

Plugin Details
A homebridge plugin to control Tuya based devices.

@iRayanKhan iRayanKhan added the pending the label given to a new verification/icon request label Mar 3, 2021
@github-actions
Copy link

github-actions bot commented Mar 3, 2021

The following pre-checks failed:

❌ Missing config.schema.json.

Comment /check to run checks again.

@iRayanKhan
Copy link
Author

The following pre-checks failed:

❌ Missing config.schema.json.

Comment /check to run checks again.

Commit 299c9b8 would beg to differ.

The schema isn't in the npm package yet, awaiting for this to be approved before releasing v2.0

@donavanbecker
Copy link
Contributor

/check

@github-actions
Copy link

github-actions bot commented Mar 3, 2021

The following pre-checks failed:

❌ Missing config.schema.json.

Comment /check to run checks again.

@donavanbecker
Copy link
Contributor

@iRayanKhan you will have to release v2.0.0

@donavanbecker donavanbecker changed the title Review request for homebridge-tuya homebridge-tuya Mar 4, 2021
@iRayanKhan
Copy link
Author

@donavanbecker can I seed it as 2.0.0-beta.1, or does it have to be a release?

@donavanbecker
Copy link
Contributor

@iRayanKhan Sure

@donavanbecker
Copy link
Contributor

@iRayanKhan are you going to release 2.0.0-beta.1?

@iRayanKhan
Copy link
Author

@donavanbecker yeah gimme like 20 min

@iRayanKhan
Copy link
Author

@donavanbecker Published as 2.0.0-beta.5

@donavanbecker
Copy link
Contributor

  • - The plugin must successfully install.
  • - The plugin must implement the Homebridge Plugin Settings GUI.
  • - The plugin must not start unless it is configured.
  • - The plugin must not execute post-install scripts that modify the user's system in any way.
  • - The plugin must not contain any analytics or calls that enable you to track the user.
  • - The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors.
  • - The plugin must be published to npm and the source code available on GitHub.
  • - The plugin must run on all Active LTS versions of Node.js, at the time of writing this is Node.js v10 and v12.
  • - The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
  • - If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.

Everything looks good!

@donavanbecker donavanbecker added verified use when a plugin meets the criteria - adds the verified badge text and removed pending the label given to a new verification/icon request labels Mar 12, 2021
@github-actions
Copy link

Congratulations! Your plugin has been verified.

You can now add the Verified by Homebridge badge to your plugin's README:

verified-by-homebridge

[![verified-by-homebridge](https://badgen.net/badge/homebridge/verified/purple)](https://github.com/homebridge/homebridge/wiki/Verified-Plugins)

Your plugin is now also eligible to display a ❤️ Donate button on it's tile in the Homebridge UI. See https://github.com/oznu/homebridge-config-ui-x/wiki/Developers:-Donation-Links for instructions.

Thank you for your contribution to the Homebridge Community.
https://homebridge.io

@donavanbecker
Copy link
Contributor

@iRayanKhan please public v2.0.0 before I push this into the verified plugins.json so that anyone install homebridge-tuya gets v2.0.0 and knows its verified.

@iRayanKhan
Copy link
Author

Thank you!

Will add the badge and seed v2.0.0 now

@iRayanKhan
Copy link
Author

@donavanbecker V2.0.0 is now live.

Thank you so much!

@donavanbecker
Copy link
Contributor

Screen Shot 2021-03-13 at 10 24 16 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verified use when a plugin meets the criteria - adds the verified badge text
Projects
None yet
Development

No branches or pull requests

2 participants