Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homebridge-evohome #63

Closed
luc-ass opened this issue May 2, 2020 · 12 comments
Closed

homebridge-evohome #63

luc-ass opened this issue May 2, 2020 · 12 comments
Labels
verified use when a plugin meets the criteria - adds the verified badge text

Comments

@luc-ass
Copy link

luc-ass commented May 2, 2020

Plugin Details
This plugin integrates Honeywell Evohome (https://getconnected.honeywellhome.com/de/thermostate/evohome) into Homebridge. It has been running smoothly for some years now. At this point I feel that it is ready for prime time. I added support for config-ui-x (config.schema.json) and created my first release.

Thank you for all your great work!

@luc-ass luc-ass added the pending the label given to a new verification/icon request label May 2, 2020
@github-actions
Copy link

github-actions bot commented May 2, 2020

✅ Pre-checks completed successfully.

@donavanbecker
Copy link
Contributor

  • - The plugin must successfully install.
  • - The plugin must implement the Homebridge Plugin Settings GUI.
  • - The plugin must not start unless it is configured.
  • - The plugin must not execute post-install scripts that modify the user's system in any way.
  • - The plugin must not contain any analytics or calls that enable you to track the user.
  • - The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors.
  • - The plugin must be published to npm and the source code available on GitHub.
  • - The plugin must run on all Active LTS versions of Node.js, at the time of writing this is Node.js v10 and v12.
  • - The plugin must not require the user to run Homebridge in a TTY or with non-standard startup parameters, even for initial configuration.
  • - If the plugin needs to write files to disk (cache, keys, etc.), it must store them inside the Homebridge storage directory.

The plugin must not throw unhandled exceptions, the plugin must catch and log its own errors.
If receive invalid login or grant, plugin stops homebridge from running.

Error during Login: invalid_grant

Screen Shot 2020-05-02 at 7 56 24 AM

@donavanbecker donavanbecker added awaiting-changes use after review has started - awaiting user to make changes to plugin and removed pending the label given to a new verification/icon request labels May 2, 2020
@donavanbecker
Copy link
Contributor

@luc-ass, you need to call callback([]) in these errors to prevent homebridge from blocking.
https://github.com/luc-ass/homebridge-evohome/blob/master/index.js#L176-L190

@luc-ass
Copy link
Author

luc-ass commented May 2, 2020

Just so I can get this right: you did not enter any credentials and homebridge stopped because of this?

@donavanbecker
Copy link
Contributor

@luc-ass I added incorrect credentials and it stopped Homebridge from running. The plugin must log it’s own. And must keep Homebridge running even if wrong credentials are inputted.

@luc-ass
Copy link
Author

luc-ass commented May 2, 2020

Thank you so much for your input! I fixed the crashing problems if no or wrong credentials are set up.

I don’t quite understand what “must log it’s own” is supposed to mean. Could you elaborate? Am I supposed to create a separate log file?

@luc-ass
Copy link
Author

luc-ass commented May 2, 2020

@donavanbecker I published a new version to npm (v0.7.1). Would you have a look at it?

@donavanbecker
Copy link
Contributor

I don’t quite understand what “must log it’s own” is supposed to mean. Could you elaborate? Am I supposed to create a separate log file?

Sorry, my wording was wrong. what you changed was exactly what I was meaning. Everything looks good. I will get it on the verified list as soon as I can.

@donavanbecker donavanbecker added verified use when a plugin meets the criteria - adds the verified badge text and removed awaiting-changes use after review has started - awaiting user to make changes to plugin labels May 3, 2020
@donavanbecker
Copy link
Contributor

/check

@github-actions
Copy link

github-actions bot commented May 3, 2020

✅ Pre-checks completed successfully.

@donavanbecker
Copy link
Contributor

Screen Shot 2020-05-03 at 4 08 15 PM

@luc-ass
Copy link
Author

luc-ass commented Oct 26, 2022

@donavanbecker we have run into problems because of the empty callback. This causes the accessories to be removed if the server doesn't respond (for example because of maintenance). Is there an alternative to callback([]), that prevents the plugin from blocking and marks existing accessories as "Not responding"? So far my searches didn't result in a solution...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
verified use when a plugin meets the criteria - adds the verified badge text
Projects
None yet
Development

No branches or pull requests

2 participants