This repository has been archived by the owner on Dec 24, 2024. It is now read-only.
fix: small fixes to the types and implement cjs2esm #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I updated the dependencies and I re installed Jimple as a development dependency, just for the type.
This is actually a 'docs:', but I need to trigger a release.
I changed the prepare script to prepublishOnly and instead of doing the transformation manually, I installed cjs2esm: it does the same, but it also fixes the issue with the missing extensions.
homer0
changed the title
|
🎉 This PR is included in version 4.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The two highlights of this PR are:
cjs2esmfor the ESM version generation; it's a wrapper on top of the script I already had here, but it also takes care of adding the extensions on the import statements.How should it be tested manually?