Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev mode is not respected when MIX_ENV is configured via environment variable #94

Closed
joshuap opened this issue Oct 10, 2017 · 1 comment
Labels

Comments

@joshuap
Copy link
Member

joshuap commented Oct 10, 2017

Running the phoenix server like this, no errors should be reported because dev is an excluded env:

MIX_ENV=dev HONEYBADGER_API_KEY=secret mix phx.server

The result is that errors are reported, however. I think it's because the values in the excluded_envs configuration option are atoms, but when configured via an environment variable the env config option is a string.

I think that when reading the MIX_ENV environment variable we should convert it to an atom, since that seems to be what Mix does. Another option might be to get the value from Mix.env rather than the environment variable itself.

@joshuap
Copy link
Member Author

joshuap commented Oct 11, 2017

Note: #96 should fix this (thanks @sorentwo!) so we just need to review/verify and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant