feat: allow Notify to receive *http.Request #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rykov
force-pushed
the
request-extra
branch
2 times, most recently
from
5046808
to
13a3114
Compare
rykov
force-pushed
the
request-extra
branch
from
13a3114
to
143f800
Compare
stympy
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
The library provides an
http.Handlerwrapper to populate panic notices with*http.Requestmetadata. However, the extraction of that metadata is not exposed via a public API. We have our own panic/recovery middleware, and including request metadata extraction in the API would be a welcome simplification for capturing panics in an HTTP server environment.Todos