Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: only allow for insights to be enabled when public #642

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

roelbondoc
Copy link
Member

This means that the gem must be able to report data as well requiring the environment to not be a development_environment. This should prevent any unexpected Insights related code to run in dev or test environments.

Before submitting a pull request, please make sure the following is done:

  1. If you've fixed a bug or added code that should be tested, add tests!
  2. Run rake spec in the repository root.
  3. Use a pull request title that conforms to conventional commits.

This means that the gem must be able to report data as well requiring
the environment to not be a `development_environment`. This should
prevent any unexpected Insights related code to run in dev or test
environments.
@roelbondoc roelbondoc requested a review from a team November 14, 2024 15:34
@roelbondoc roelbondoc merged commit 2d3ab26 into master Nov 14, 2024
59 checks passed
@roelbondoc roelbondoc deleted the feat-only-enable-insights-if-public branch November 14, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants