Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OTLP Logs support #237

Open
cartermp opened this issue Aug 21, 2022 · 4 comments
Open

Add OTLP Logs support #237

cartermp opened this issue Aug 21, 2022 · 4 comments
Labels
type: enhancement New feature or request

Comments

@cartermp
Copy link
Member

Since we support them on our endpoint!

@cartermp cartermp added the type: enhancement New feature or request label Aug 21, 2022
@cartermp
Copy link
Member Author

Note: this would require taking a dependency on this package (for now?) - https://www.nuget.org/packages/OpenTelemetry.Exporter.OpenTelemetryProtocol.Logs/1.4.0-alpha.2

@cartermp
Copy link
Member Author

I did a quick spike on this and it's pretty easy to add. That said, I think, given that there's a lot more churn in the upstream SDK, we should only add it as a part of our AddHoneycomb call and not expose public extensions to ILoggerBuilder. My reasons:

  1. I think it is likely that they may also include a LoggerProviderBuilder type that you're expected to extend and add your own logger to
  2. Serilog is so widely-used that they may even just add a sink to the project and let you configure it
  3. API churn in general

Rather than ship extensions to a thing that may undergo churn, we should make it internal for now and no expose any API for people to call. I still think it's valuable to add logs support, so let's not let this deter us from adding them. Lots of folks use the microsoft logging framework and could benefit from having those logs "just work" when honeycomb is added.

@MikeGoldsmith MikeGoldsmith added this to the GA Release milestone Aug 24, 2022
@cartermp
Copy link
Member Author

@MikeGoldsmith and I chatted and think that this should probably get punted, or at least just done orthogonally to the release. The issue is that it requires pulling in prerelease packages, which we can't do if we want to make our distro actually GA. We can build a honeycomb logging exporter package and release it separately for now.

@cartermp cartermp removed this from the GA Release milestone Sep 17, 2022
@MikeGoldsmith MikeGoldsmith changed the title Also support logs Add OTLP Logs support Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants