-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OTLP Logs support #237
Comments
Note: this would require taking a dependency on this package (for now?) - https://www.nuget.org/packages/OpenTelemetry.Exporter.OpenTelemetryProtocol.Logs/1.4.0-alpha.2 |
I did a quick spike on this and it's pretty easy to add. That said, I think, given that there's a lot more churn in the upstream SDK, we should only add it as a part of our
Rather than ship extensions to a thing that may undergo churn, we should make it internal for now and no expose any API for people to call. I still think it's valuable to add logs support, so let's not let this deter us from adding them. Lots of folks use the microsoft logging framework and could benefit from having those logs "just work" when honeycomb is added. |
@MikeGoldsmith and I chatted and think that this should probably get punted, or at least just done orthogonally to the release. The issue is that it requires pulling in prerelease packages, which we can't do if we want to make our distro actually GA. We can build a honeycomb logging exporter package and release it separately for now. |
Since we support them on our endpoint!
The text was updated successfully, but these errors were encountered: