Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SpanLimit shouldn't set SendDelay #1270

Closed
kentquirk opened this issue Aug 14, 2024 · 0 comments · Fixed by #1272
Closed

SpanLimit shouldn't set SendDelay #1270

kentquirk opened this issue Aug 14, 2024 · 0 comments · Fixed by #1272
Assignees
@kentquirk
Labels
type: enhancement New feature or request
Milestone
v2.8

Comments

@kentquirk
Copy link
Contributor

Is your feature request related to a problem? Please describe.

If a trace hits the SpanLimit, that means we're in danger of excessive memory pressure. We should not add a SendDelay when this happens.

Describe the solution you'd like

Ignore SendDelay in this case.

Describe alternatives you've considered

Crashing or OOM Kill

Additional context
@kentquirk kentquirk added the type: enhancement New feature or request label Aug 14, 2024
@kentquirk kentquirk added this to the v2.8 milestone Aug 14, 2024
@kentquirk kentquirk self-assigned this Aug 14, 2024
@kentquirk kentquirk mentioned this issue Aug 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kentquirk kentquirk

Labels
type: enhancement New feature or request
Projects
None yet
Milestone
v2.8
Development

Successfully merging a pull request may close this issue.

fix: SpanLimit shouldn't add SendDelay honeycombio/refinery
1 participant
@kentquirk