Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document DryRun mode will not work when EnableTraceLocality is set to true #1361

Closed
VinozzZ opened this issue Oct 3, 2024 · 0 comments · Fixed by #1418
Closed

Document DryRun mode will not work when EnableTraceLocality is set to true #1361

VinozzZ opened this issue Oct 3, 2024 · 0 comments · Fixed by #1418
Assignees
Milestone

Comments

@VinozzZ
Copy link
Contributor

VinozzZ commented Oct 3, 2024

When trace locality is disabled, the system currently publishes drop decisions with only trace IDs. This approach does not provide enough information for peers to decorate spans with the original metadata generated during trace decisions, which is available when trace locality is enabled.

We have decided not to support dry-run mode in the upcoming changes related to removing trace locality.
We should make sure to document this when the feature is released

@VinozzZ VinozzZ added this to the v2.9 milestone Oct 3, 2024
@akvanhar akvanhar changed the title DryRun mode will not work when EnableTraceLocality is set to true Document DryRun mode will not work when EnableTraceLocality is set to true Oct 31, 2024
@MikeGoldsmith MikeGoldsmith self-assigned this Nov 5, 2024
@VinozzZ VinozzZ closed this as completed in 1ef4c32 Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants