Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default environment prefix to allow environments and dataset with same name in rules file #408

Closed
MikeGoldsmith opened this issue Feb 17, 2022 · 2 comments · Fixed by #438
Assignees
Labels
type: enhancement New feature or request

Comments

@MikeGoldsmith
Copy link
Contributor

Is your feature request related to a problem? Please describe.
When configuring refinery rules, you cannot specify both an environment and dataset with the same name. This is possible to configure in Honeycomb - eg a legacy production dataset and a production environment.

Describe the solution you'd like
Add a legacy dataset prefix config setting that differentiate between environments and datasets.

The default would be empty, so no prefix is used.

eg
config.toml

...
LegacyDatasetPrefix = "legacy"
...

rules.toml


# environment
[production]
...

# dataset
[legacy.production]
...

Describe alternatives you've considered

Additional context

@MikeGoldsmith MikeGoldsmith added the type: enhancement New feature or request label Feb 17, 2022
@vreynolds vreynolds assigned vreynolds and unassigned vreynolds Feb 22, 2022
@seh
Copy link
Contributor

seh commented Feb 28, 2022

Rather than "legacy" being the default prefix, consider the word "dataset" as an alternative.

@MikeGoldsmith
Copy link
Contributor Author

@seh I've created the PR to allow a dataset prefix. Feel free to take a look 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants