Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow nested JSON fields for rules sampling config #413

Closed
ecobrien29 opened this issue Feb 25, 2022 · 1 comment · Fixed by #418
Closed

allow nested JSON fields for rules sampling config #413

ecobrien29 opened this issue Feb 25, 2022 · 1 comment · Fixed by #418
Labels
status: help wanted Seeking more eyes and hands. type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible.

Comments

@ecobrien29
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Yes, our logs have nested JSON fields that we would like to use for sampling decisions. The current code looks like it does not allow this functionality.

Describe the solution you'd like
I would like to modify the code here to also use a get function if the value isn't found in order to have it read nested JSON, but also retain the original functionality for fields with a name including a '.'

Describe alternatives you've considered

Additional context

@ecobrien29 ecobrien29 added the type: enhancement New feature or request label Feb 25, 2022
@MikeGoldsmith
Copy link
Contributor

Thanks for raising this @ecobrien29. We will take a look and add to our backlog for prioritisation.

We're also very open to community contributions, so if you feel so inclined we'd welcome a PR 👍🏻

@MikeGoldsmith MikeGoldsmith added status: help wanted Seeking more eyes and hands. version: bump minor A PR that adds behavior, but is backwards-compatible. labels Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: help wanted Seeking more eyes and hands. type: enhancement New feature or request version: bump minor A PR that adds behavior, but is backwards-compatible.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants