Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maxkeys and keyspace size as metrics for dynamic samplers #554

Closed
puckpuck opened this issue Nov 1, 2022 · 1 comment · Fixed by #714
Closed

Add maxkeys and keyspace size as metrics for dynamic samplers #554

puckpuck opened this issue Nov 1, 2022 · 1 comment · Fixed by #714
Assignees
Labels
type: enhancement New feature or request
Milestone

Comments

@puckpuck
Copy link
Contributor

puckpuck commented Nov 1, 2022

Is your feature request related to a problem? Please describe.
An improperly configured set of fields used to create the keyspace used by the dynamic sampler can be difficult to diagnose.

Describe the solution you'd like
Have dynamic samplers report the MaxKeys configuration property and current keyspace size. Since multiple dynamic samplers can be used, each one would need a unique name to be identified. For samplers configured directly on a dataset/environment then, <dataset> should be used. For samplers configured as part of a Rules-based configuration the name should be <dataset>-<rule-index>-<rule-name>

@puckpuck puckpuck added the type: enhancement New feature or request label Nov 1, 2022
@kentquirk
Copy link
Contributor

Additional request for both keyspace cardinality (number of items in the keyspace) as well keyspace size in bytes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants